refactor(pool): use sleep instead of sleep_until#233
Closed
dswij wants to merge 1 commit intohyperium:masterfrom
Closed
refactor(pool): use sleep instead of sleep_until#233dswij wants to merge 1 commit intohyperium:masterfrom
sleep instead of sleep_until#233dswij wants to merge 1 commit intohyperium:masterfrom
Conversation
This commit refactors all usage of `Timer::sleep_until` with `Timer::sleep`. `sleep_until` is a convenient method that is logically equivalent with `sleep`, but requires the use of `std::time::Instant`. This have some effect when downstream users rely on non-std `Instant`.
seanmonstar
reviewed
Sep 17, 2025
| } | ||
|
|
||
| let deadline = Instant::now() + self.duration; | ||
| self.timer.reset(&mut sleep, deadline); |
Member
There was a problem hiding this comment.
This call has the benefit of allowing implementors to reuse an allocated sleep, instead of allocating a new one...
Member
Author
There was a problem hiding this comment.
That's true. But I wonder if reuse instead of allocation has that much of an impact in practice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the usage of
Timer::sleep_untilwithTimer::sleep.sleep_untilis a convenient method that is logically equivalent withsleep, but requires the use ofstd::time::Instant. This have some effect when downstream users rely on non-stdInstant.